Conversation
Feature/13 user
* feat : google login 구현 완료 (ios 구현 중)
* feat : google login 구현 완료 * fix : user hard delete * feat : apple 로그인 구현 및 ddl-auto -> update 변경
* 약관 엔티티 생성 및 연관관계 설정 * 회원가입에 약관 저장 로직 추가 * 서버에서 idToken을 받아올 수 없으므로 단순히 이메일로 accessToken을 받아오는 test API 추가
* feat : 파티 엔티티 정의 * feat : 파티 dto * feat : party dto 정의 * feat : party entity 정의 * feat : 파티 생성,수정,삭제, 조회 partycontroller partyservice partyrepository * feat : 거리 계산 클래스 * refactor : 불필요한 코드 삭제 * refactor : token provider로 유저 아이디 추출하도록 변경 * Fix: 파티 기능 버그 수정 * docs : 파티 swagger 문서 추가
* feat : 파티 검색 추가
* feature & fix : 유저 최근 검색어 API 구현
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthrough파티 목록 조회 기능에 거리 기반 정렬 지원이 추가되었습니다. 컨트롤러에서 sortType, userLat, userLon 파라미터를 받아 PartyListRequest 객체로 구성한 후 서비스에 전달합니다. 서비스는 정렬 타입에 따라 거리 또는 최신순으로 파티를 조회하고 정렬합니다. 거리 기반 정렬 시에는 PartyCardResponse의 distanceKm 필드에 포맷된 거리 문자열을 설정합니다. DistanceCalculator의 formatDistance 메서드는 1km 미만의 거리를 소수점 한 자리의 킬로미터 형식으로 반환하도록 수정되었습니다. Sequence DiagramsequenceDiagram
participant Client
participant Controller as PartyController
participant Service as PartyService
participant DB as Repository
participant Calculator as DistanceCalculator
Client->>Controller: GET /parties?category=...&sortType=DISTANCE<br/>&userLat=37.5&userLon=126.9
rect rgb(220, 240, 255)
Note over Controller: 파라미터 검증
Controller->>Controller: sortType이 DISTANCE인 경우<br/>위도/경도 범위 검증
end
Controller->>Controller: PartyListRequest 생성<br/>(category, sortType, userLat, userLon)
Controller->>Service: getPartyList(userId, request)
rect rgb(220, 255, 220)
Note over Service: 파티 조회
Service->>DB: findByCategory() 또는<br/>fetchPartiesByLocation()
DB-->>Service: Party 리스트
end
alt sortType == DISTANCE
rect rgb(255, 240, 220)
Note over Service: 거리 기반 정렬
loop 각 Party마다
Service->>Calculator: calculateDistance(party.lat, party.lon,<br/>userLat, userLon)
Calculator-->>Service: distance (Double)
Service->>Service: convertToCardResponseWithDistance<br/>(party, distance)
Service->>Calculator: formatDistance(distance)
Calculator-->>Service: 포맷된 거리 (String)
end
Service->>Service: DISTANCE 기준으로 정렬
end
else sortType == LATEST
Service->>Service: LATEST 기준으로 정렬
end
Service-->>Controller: PartyListResponse
Controller-->>Client: 200 OK with parties
Possibly related PRs
✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jan 6, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 상세 내용
Summary by CodeRabbit
릴리즈 노트
✏️ Tip: You can customize this high-level summary in your review settings.